Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UTXO & Tx Inputs streaming #570

Merged
merged 6 commits into from
Sep 16, 2022
Merged

Support UTXO & Tx Inputs streaming #570

merged 6 commits into from
Sep 16, 2022

Conversation

samuelmanzanera
Copy link
Member

Description

This PR provides a way to stream UTXOs and Transaction inputs to avoid timeouts in case of many data to download.
This would be used in the mining, UI and API.

Fixes #568

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added feature New feature request P2P Involve P2P networking mining Involve transaction validation and mining UI Invole user interface API Involve API facing user labels Sep 14, 2022
@samuelmanzanera samuelmanzanera changed the title Utxo streaming Support UTXO & Tx Inputs streaming Sep 14, 2022
@samuelmanzanera
Support stream of UTXO
7b75856 
The aim is to reduce timeouts by streaming into batches  < 3MB.
This would be used to retrieve all the UTXO in the transaction context phase of the mining.
Neylix
Neylix requested changes Sep 15, 2022
View reviewed changes
lib/archethic/p2p/message.ex Outdated Show resolved Hide resolved
lib/archethic_web/graphql_schema/resolver.ex Outdated Show resolved Hide resolved
lib/archethic_web/graphql_schema/resolver.ex Show resolved Hide resolved
@samuelmanzanera samuelmanzanera merged commit c60dc07 into develop Sep 16, 2022
@samuelmanzanera samuelmanzanera deleted the utxo_streaming branch September 16, 2022 08:53
@samuelmanzanera samuelmanzanera mentioned this pull request Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neylix Neylix Neylix approved these changes

Assignees
No one assigned
Labels
API Involve API facing user feature New feature request mining Involve transaction validation and mining P2P Involve P2P networking UI Invole user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelmanzanera @Neylix